Closed Bug 255947 Opened 20 years ago Closed 19 years ago

missing borders for the progress bar with native classic widget on windows

Categories

(Core Graveyard :: GFX: Win32, defect)

x86
Windows XP
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nirvn.asia, Assigned: nirvn.asia)

References

Details

(Keywords: polish, Whiteboard: [windows classic theme only])

Attachments

(4 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040816 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040816 Firefox/0.9.1+

The Update dialog progress bar is missing borders when you are not using any xp
themes (luna, luna grey, etc. etc. etc.) .. so basicaly when you are in classic
view, you have a visual glitch on this dialog

Reproducible: Always
Steps to Reproduce:
1.Run WinXP with Classic theme
2.Open the Update dialog of firefox


Actual Results:  
The dialog is showing a progress bar without borders

Expected Results:  
Show a progress bar with borders

I put it minor instead of trivial because the user doesnt see any boundaries see
the time to wait for the end of the update check is not obvious.
Flags: blocking-aviary1.0PR?
Flags: blocking-aviary1.0?
Attached image progress without border
this happens in winxp, I dont know if it's the same with win2k, winnt and
win9x/me  ... should be fixed as most of the people doesnt use the luna theme
(a lot of users are not using winxp anyway) and will face this bug
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR-
Keywords: polish
WFM. Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago
Resolution: --- → WORKSFORME
Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040915 Firefox/0.10

there is no border on a win xp machine, using classic theme (i.e. no luna theme,
just ordinary windows scheme)

Wolf, were you using the luna theme or no theme ? check the screenshot attached
to this bug if you dont understand what I mean by no theme
Status: RESOLVED → UNCONFIRMED
Resolution: WORKSFORME → ---
not a blocker.
Flags: blocking-aviary1.0? → blocking-aviary1.0-
Severity: minor → trivial
Whiteboard: windows classic theme only
... just so we put things on perspective:

 your telling me that a basic visual way to know the % done for a task (i.e.
your update system) is screwed up on win98,winME,winNT4,win2k,win2k3 and winXP
with classic theme and is not worth putting resource for your 1.1 release? ! ?
straightfoward patch, I think it was probably forgotten, when switching from
css widget to native windows widget, to add a border to the classic
(win9x,nt,2k,xp classic) widget drawing parts.

update dialog doesn't suck anymore with native classic widget.
Oh, please add a comment "// fall through" just before you fall through to the
next "case ...:" statement
Component: Software Update → GFX: Win32
Product: Firefox → Core
Version: unspecified → Trunk
changed the product and summary + requesting blocking core 1.8b2/firefox 1.1
Summary: missing borders for the progress bar in the update dialog → missing borders for the progress bar with native classic widget on windows
Comment on attachment 180771 [details] [diff] [review]
fall through comment added

carried forward r+
Attachment #180771 - Flags: superreview+
Attachment #180771 - Flags: review+
Flags: blocking1.8b2?
Flags: blocking-aviary1.1?
Comment on attachment 180771 [details] [diff] [review]
fall through comment added

fixes the lack of borders with progress bars on win32 platform using classic
theme
Attachment #180771 - Flags: approval1.8b2?
Assignee: bugs → nirvn.asia
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: bugs → ian
Flags: blocking1.8b2?
Flags: blocking1.8b2-
Flags: blocking-aviary1.0PR-
Flags: blocking-aviary1.0-
Comment on attachment 180771 [details] [diff] [review]
fall through comment added

let's push this out until the next release. we're down to endgame on 1.8b2 and
shouldn't be adding more risk at this point.
Attachment #180771 - Flags: approval1.8b3?
Attachment #180771 - Flags: approval1.8b2?
Attachment #180771 - Flags: approval1.8b2-
asa, the only thing that this patch adds is a win32 DrawEdge function; one
single line of code added that truly represent no risks at all for gecko ...
That's what this patch is all about.
Comment on attachment 180771 [details] [diff] [review]
fall through comment added

a=shaver
Attachment #180771 - Flags: approval1.8b3? → approval1.8b3+
Comment on attachment 180771 [details] [diff] [review]
fall through comment added

This needs to be checked in.
Whiteboard: windows classic theme only → [windows classic theme only][checkin needed]
ping? c'mon, it's getting ridiculous. So much for trying to get new programmers
to get involved into mozilla products.
Sadly none of the people cc'ed on this bug have CVS access. I recommend trying
to find a check-in buddy on irc.mozilla.org channel #developers.
Fixed on trunk.  Sorry no one got to this sooner, just ask in #developers and
usually someone can land for you.  Thanks for the patch!
Status: NEW → RESOLVED
Closed: 20 years ago19 years ago
Flags: blocking-aviary1.1?
Resolution: --- → FIXED
I went to #developers a while ago, I'll remember next time: add a guy that has
cvs access to the CC list. Thanks for that quick pong!
*** Bug 298604 has been marked as a duplicate of this bug. ***
Attached image Status bar bevel
This patch has made the progress bar in the status bar bevel'd too. Expected, I
guess, but it looks a little strange (perhaps because I am not used to it. But
anyway, i thought i'd document it).
It's more than expected, it's what it should be! :) Do you have borders when
using luna themes? yes. Do you have borders under linux? yes. Under mac? yes.

They are using a progress bar widget in the statusbar, of course you'll have
borders. 
Wrong. The statusbar panel *is* the progressbar, or should be visually. Yes,
theming messes it up and forces them to be split, but in other cases it should
not happen. See:

http://lxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/progressmeter.css#66

That clearly tries to remove the borders, but neglects to turn off
-moz-appearance (or somehow tell it to be border-less).
Also, it seems, the native theme for standalone progrssbars is wrong anyway -
there should be a 1px gap between the sunken border and the colour block. See:

http://lxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/progressmeter.css#44

Do native apperance right, or not at all, please. ;)
Whiteboard: [windows classic theme only][checkin needed] → [windows classic theme only]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: