255947 - missing borders for the progress bar with native classic widget on windows

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Win32, defect)

Description

[Mathieu Pellerin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040816 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040816 Firefox/0.9.1+

The Update dialog progress bar is missing borders when you are not using any xp
themes (luna, luna grey, etc. etc. etc.) .. so basicaly when you are in classic
view, you have a visual glitch on this dialog

Reproducible: Always
Steps to Reproduce:
1.Run WinXP with Classic theme
2.Open the Update dialog of firefox


Actual Results:  
The dialog is showing a progress bar without borders

Expected Results:  
Show a progress bar with borders

I put it minor instead of trivial because the user doesnt see any boundaries see
the time to wait for the end of the update check is not obvious.

Comment 1

[Mathieu Pellerin]

Attachment: progress without border

this happens in winxp, I dont know if it's the same with win2k, winnt and
win9x/me  ... should be fixed as most of the people doesnt use the luna theme
(a lot of users are not using winxp anyway) and will face this bug

Comment 2

[Wolf [:wolf]]

WFM. Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10

Comment 3

[Mathieu Pellerin]

Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040915 Firefox/0.10

there is no border on a win xp machine, using classic theme (i.e. no luna theme,
just ordinary windows scheme)

Wolf, were you using the luna theme or no theme ? check the screenshot attached
to this bug if you dont understand what I mean by no theme

Comment 4

[Asa Dotzler [:asa]]

not a blocker.

Comment 5

[Mathieu Pellerin]

... just so we put things on perspective:

 your telling me that a basic visual way to know the % done for a task (i.e.
your update system) is screwed up on win98,winME,winNT4,win2k,win2k3 and winXP
with classic theme and is not worth putting resource for your 1.1 release? ! ?

Comment 6

[Mathieu Pellerin]

Attachment: add border to progress bar for native classic windows widget

straightfoward patch, I think it was probably forgotten, when switching from
css widget to native windows widget, to add a border to the classic
(win9x,nt,2k,xp classic) widget drawing parts.

update dialog doesn't suck anymore with native classic widget.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Oh, please add a comment "// fall through" just before you fall through to the
next "case ...:" statement

Comment 8

[Mathieu Pellerin]

Attachment: fall through comment added

Comment 9

[Mathieu Pellerin]

changed the product and summary + requesting blocking core 1.8b2/firefox 1.1

Comment 10

[Mathieu Pellerin]

Comment on attachment 180771 [details] [diff] [review]
fall through comment added

carried forward r+

Comment 11

[Mathieu Pellerin]

Comment on attachment 180771 [details] [diff] [review]
fall through comment added

fixes the lack of borders with progress bars on win32 platform using classic
theme

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 180771 [details] [diff] [review]
fall through comment added

let's push this out until the next release. we're down to endgame on 1.8b2 and
shouldn't be adding more risk at this point.

Comment 13

[Mathieu Pellerin]

asa, the only thing that this patch adds is a win32 DrawEdge function; one
single line of code added that truly represent no risks at all for gecko ...
That's what this patch is all about.

Comment 14

[Mike Shaver (:shaver emeritus)]

Comment on attachment 180771 [details] [diff] [review]
fall through comment added

a=shaver

Comment 15

[Caleb]

Comment on attachment 180771 [details] [diff] [review]
fall through comment added

This needs to be checked in.

Comment 16

[Mathieu Pellerin]

ping? c'mon, it's getting ridiculous. So much for trying to get new programmers
to get involved into mozilla products.

Comment 17

[Hixie (not reading bugmail)]

Sadly none of the people cc'ed on this bug have CVS access. I recommend trying
to find a check-in buddy on irc.mozilla.org channel #developers.

Comment 18

[Mike Connor [:mconnor]]

Fixed on trunk.  Sorry no one got to this sooner, just ask in #developers and
usually someone can land for you.  Thanks for the patch!

Comment 19

[Mathieu Pellerin]

I went to #developers a while ago, I'll remember next time: add a guy that has
cvs access to the CC list. Thanks for that quick pong!

Comment 20

[Masatoshi Kimura [:emk]]

*** Bug 298604 has been marked as a duplicate of this bug. ***

Comment 21

[Steve England [:stevee]]

Attachment: Status bar bevel

This patch has made the progress bar in the status bar bevel'd too. Expected, I
guess, but it looks a little strange (perhaps because I am not used to it. But
anyway, i thought i'd document it).

Comment 22

[Mathieu Pellerin]

It's more than expected, it's what it should be! :) Do you have borders when
using luna themes? yes. Do you have borders under linux? yes. Under mac? yes.

They are using a progress bar widget in the statusbar, of course you'll have
borders. 

Comment 23

[James Ross]

Wrong. The statusbar panel *is* the progressbar, or should be visually. Yes,
theming messes it up and forces them to be split, but in other cases it should
not happen. See:

http://lxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/progressmeter.css#66

That clearly tries to remove the borders, but neglects to turn off
-moz-appearance (or somehow tell it to be border-less).

Comment 24

[James Ross]

Also, it seems, the native theme for standalone progrssbars is wrong anyway -
there should be a 1px gap between the sunken border and the colour block. See:

http://lxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/progressmeter.css#44

Do native apperance right, or not at all, please. ;)